Produce deprecated property in JsonSchema for obsolete types by Youssef1313 · Pull Request #130665 · dotnet/runtime

Youssef1313 · 2026-07-14T06:41:15Z

Spec: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-01#section-9.3

Copilot

Pull request overview

This PR updates the System.Text.Json JSON Schema exporter to emit the JSON Schema deprecated keyword when exporting schemas for [Obsolete] .NET types, and adds a regression test covering the new behavior.

Changes:

Detect [Obsolete] on exported types and set deprecated: true in the generated schema.
Add Deprecated support to the internal JsonSchema model and include it in JSON output.
Add a unit test validating deprecated is emitted for an obsolete type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs	Adds a test case validating `deprecated` is produced for an `[Obsolete]` type.
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs	Marks exported schemas as deprecated when the associated .NET type has `[Obsolete]`.
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs	Adds a `Deprecated` keyword to the schema model, counts it, and emits it during JSON serialization.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

dotnet-policy-service · 2026-07-14T06:54:30Z

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

eiriktsarpalis

Thanks

Youssef1313 · 2026-07-16T06:21:33Z

@copilot Read_NonGeneric_NoPublicConstructor_Throws has failed. Investigate if it's flakiness or bug introduced in this PR.

    System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.Read_NonGeneric_NoPublicConstructor_Throws(type: typeof(System.Text.Json.Serialization.Tests.WrapperForIEnumerablePrivateConstructor), json: "[\"1\"]") [FAIL]
      System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.NonGeneric.Read.cs(593,0): at System.Text.Json.Serialization.Tests.CollectionTests.Read_NonGeneric_NoPublicConstructor_Throws(Type type, String json)
        --- End of stack trace from previous location ---

Copilot · 2026-07-16T06:57:02Z

@copilot Read_NonGeneric_NoPublicConstructor_Throws has failed. Investigate if it's flakiness or bug introduced in this PR.

...

Investigated this failure in detail:

Failing leg is runtime build 1509786, job Libraries Test Run release coreclr windows x86 Release, Helix job 3d4eef7e-0f1e-4ac4-af2a-365ae141fcbb.
It failed with 8 variants of the same test (Read_NonGeneric_NoPublicConstructor_Throws) throwing NullReferenceException.
The same test passes locally on current PR head, including repeated runs (10/10) and full class run.
PR changes only touch JSON schema exporter/tests and do not affect deserialization path used by this collection test.

Given current evidence, this looks more like a transient/leg-specific failure than a deterministic regression from this PR. If it reappears on rerun, we should escalate to deeper x86-specific investigation.

Note

This comment was generated with AI/Copilot assistance.

Copilot AI review requested due to automatic review settings July 14, 2026 06:41

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:41 — with GitHub Actions Inactive

github-actions Bot added the area-System.Text.Json label Jul 14, 2026

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:41 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:41 View session

Youssef1313 had a problem deploying to copilot-pat-pool July 14, 2026 06:42 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:43 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:44 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 06:50

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from 2e895bf to a5d6c2d Compare July 14, 2026 06:50

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:50 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:50 View session

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from a5d6c2d to 0460d8b Compare July 14, 2026 06:51

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:51 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:52 — with GitHub Actions Inactive

Youssef1313 had a problem deploying to copilot-pat-pool July 14, 2026 06:53 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 06:54

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:54 View session

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 07:01

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from 0460d8b to 76a2de7 Compare July 14, 2026 07:01

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 07:01 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 13:21 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

eiriktsarpalis reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

eiriktsarpalis reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

This was referenced Jul 14, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

[wasm] OpenQA.Selenium.WebDriverTimeoutException: timeout: Timed out receiving message from renderer #117486

Open

Assert complete schema

f356da1

Copilot AI review requested due to automatic review settings July 15, 2026 08:23

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:24 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 15, 2026 08:24 View session

Youssef1313 had a problem deploying to copilot-pat-pool July 15, 2026 08:25 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:26 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:27 — with GitHub Actions Inactive

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

eiriktsarpalis approved these changes Jul 15, 2026

View reviewed changes

Copilot started work on behalf of Youssef1313 July 16, 2026 06:22 View session

Copilot finished work on behalf of Youssef1313 July 16, 2026 06:57

Youssef1313 mentioned this pull request Jul 17, 2026

Map [Obsolete] attribute to deprecated in OpenAPI documents dotnet/aspnetcore#66355

Merged

4 tasks

Youssef1313 merged commit dcec008 into main Jul 17, 2026
90 of 91 checks passed

Youssef1313 deleted the dev/ygerges/deprecated-schema branch July 17, 2026 20:02

dotnet-maestro Bot mentioned this pull request Jul 18, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#7841

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 18, 2026

baywet mentioned this pull request Jul 20, 2026

OpenAPI 3.2.0 just released dotnet/aspnetcore#63754

Closed

1 task

kotlarmilos mentioned this pull request Jul 21, 2026

[mobile] Skip publishing tests ignored by CI #131071

Merged

This was referenced Jul 22, 2026

Add additional test for STJ Schema deprecated property #131189

Open

Cleanup custom handling of Obsolete attribute once we get updates from STJ flowing dotnet/aspnetcore#67958

Open

Uh oh!

Conversation

Youssef1313 commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-service Bot commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

Youssef1313 commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants